Conversation
|
|
|
Thanks @mvdebolskiy :) |
rosiealice
left a comment
There was a problem hiding this comment.
Hi @mvdebolskiy this looks good. I think if/when we make a balance check we might need to do some more before we get to the summary, but given how simple this is now perhaps that reduces the potential for error.
I do think I need to add in the product pool decay flux though. I will try to add it here.
|
@rosiealice I believe there is a balance check within fates already, but it might not include soil fluxes apart from litter. |
kjetilaas
left a comment
There was a problem hiding this comment.
I agree with @rosiealice: fluxes from the product pool(s) needs to be added here. Otherwise, this looks good to me.
|
Notes on what I actually did (upon realizing we also needed product pools.
At this point I added new code to add in the product pool fluxes, and ran the test suite. Eventually all the tests passed, and I commited the code in and then we resume the instructions below...
|
Description of changes
Updated co2 flux when fates is on.
Only includes nbp calculations:
NBP=NPP-fire_closs-grazing_clossNet carbon exchange is positive to atm.
@kjetilaas, @rosiealice
To bring this in:
0. Checkout this branch.
./bin/git-fleximod update./create_test --xml-category aux_clm_noresm